-
Notifications
You must be signed in to change notification settings - Fork 35
Windows support. #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows support. #764
Conversation
Upgrade the util get_runtime_env_info() function to also return the system/OS information about the current runtime environment. Also, create three new functions to return if the current runtime environment runs on a Windows system, and ppc64 or s390x architectures. Signed-off-by: Paulo Vital <[email protected]>
Signed-off-by: Paulo Vital <[email protected]>
|
❌ @pvital the
📝 What should I do to fix it?All proposed commits should include a sign-off in their messages, ideally at the end. ❔ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO, reformatted for readability:
Contributors sign-off that they adhere to these requirements by adding a Git even has a |
c807503 to
a936f21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small docstring suggestion. Looks perfect to me otherwise!
This change adds cross-platform resource usage monitoring with Windows support: - Create new resource_usage.py module with platform-specific implementations - Add psutil dependency for Windows systems in pyproject.toml - Refactor runtime.py to use the new cross-platform resource usage functions - Implement ResourceUsage class that provides consistent interface across platforms The implementation gracefully handles platform differences, ensuring consistent metrics collection on both Unix and Windows environments. Co-authored-by: Varsha GS <[email protected]> Signed-off-by: Paulo Vital <[email protected]>
Signed-off-by: Paulo Vital <[email protected]>
This PR adds support to Windows OS. It does the following:
util get_runtime_env_info()function also to return the system/OS information about the current runtime environment.resource_usage.pymodule with platform-specific implementations.psutildependency for Windows systems inpyproject.toml.runtime.pyto use the new cross-platform resource usage functions, andResourceUsageclass that provides consistent interface across platforms.The implementation gracefully handles platform differences, ensuring consistent metrics collection on both Unix and Windows environments.